Add require_model to the brick list #93
Open
+49
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulio93
force-pushed
the
add_required_model_field
branch
from
68e4ca0 to
a091a26
Compare
lucarin91
reviewed
Nov 20, 2025
Contributor
lucarin91
left a comment
lucarin91
left a comment
There was a problem hiding this comment.
You should regenerate the openapi
giulio93
changed the title
mirkoCrobu
requested changes
Nov 20, 2025
Contributor
mirkoCrobu
left a comment
mirkoCrobu
left a comment
There was a problem hiding this comment.
You should regenerate the openapi
And after regenerating it, you can integrate "internal/e2e/daemon/brick_test.go"(test: func TestBricksList(t *testing.T) ), checking the new field.
dido18
reviewed
Nov 21, 2025
| require.Equal(t, "Image Classification", b.Name) | ||
| require.Equal(t, "mobilenet-image-classification", b.ModelName) | ||
| require.True(t, b.RequireModel) | ||
| require.True(t, b.ModelRequired) |
Contributor
There was a problem hiding this comment.
I would add two additional unit tests: "require_model: false" and a missing "require_model" in the yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR add the required_model field on brick:
Additional Notes
require_modelboolen in brick list/details #88require_modelfor the app bricks (installed into an app) #90