Skip to content

fix(update): make sure we always return underlying error #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

fix(update): make sure we always return underlying error #95

merged 1 commit into from
Nov 21, 2025

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Nov 20, 2025

Motivation

We should be sure to return the errors of the underlying command.

Change description

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@lucarin91 lucarin91 requested a review from dido18 November 20, 2025 16:22
@lucarin91 lucarin91 mentioned this pull request Nov 20, 2025
Closed
@per1234 per1234 changed the title fix(update): make sure we always return underline error fix(update): make sure we always return underlying error Nov 20, 2025
@per1234 per1234 added the bug Something isn't working label Nov 20, 2025
@lucarin91 lucarin91 merged commit f761ee6 into arduino:main Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dido18 dido18 dido18 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucarin91 @dido18 @per1234