feat: refresh converter interfaces #1731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
ianbotsf
added
the
acknowledge-api-break
|
A new generated diff is ready to view.
|
ianbotsf
added
the
no-changelog
0marperez
approved these changes
Nov 17, 2025
|
|
||
|  | ||
|
|
||
| Collection converters are typically build using factory functions which accept one or more delegate converters as |
Contributor
There was a problem hiding this comment.
Correctness: build -> built
| val byteToLong: Converter<Byte, Long> = byteToShort + shortToInt + intToLong | ||
| ``` | ||
|
|
||
| ### Element mapping |
Contributor
There was a problem hiding this comment.
Nit: The Element mapping section is missing an example of a ListMappingConverter implementation
| @@ -0,0 +1,146 @@ | |||
| # HLL Converters | |||
Contributor
There was a problem hiding this comment.
This is a really cool write up!
Contributor
There was a problem hiding this comment.
Nit: On naming (ListMappingConverter and the rest of the collection converters). Adding an s at the end of the file name to prevent people for looking for xConverter and xMonoConverter in different files.
| if (existingImport == null) { | ||
| imports += ImportDirective("${type.pkg}.${type.baseName}") | ||
| } else if (existingImport.fullName != type.fullName) { | ||
| } else if (existingImport.fullName != "${type.pkg}.${type.baseName}") { |
Contributor
There was a problem hiding this comment.
Question: Why this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#472
Description of changes
This PR refactors the converter interfaces used in DynamoDB Mapper to improve their semantics, composability, and reusability based on learnings from Dev Preview. Notable improvements:
Item/AttributeValueinstances).+/plusoperator rather thanandThenTowhich also inaccurately conveyed unidirectionality.SplittingConverterwhich was a confusing and overly-complex construct. Also removed the related classEither.ItemConverterorValueConverterto disambiguate the type of object handled.ItemConverterno longer contains a conversion overload for limiting the set of attributes to be converted, which is now handled exclusively byItem.intersectKeys.ItemConverteris now a straightforwardtypealias ItemConverter<T> = Converter<T, Item>.Review guide
There are a lot of changes in this PR but many are renames and moves. I'd advise skimming the codegen changes but paying more attention to changes in :hll-mapping-core and :dynamodb-mapper. In particular, I recommend proceeding in this fashion:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.