Skip to content

feat: refresh converter interfaces #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2025
Merged

feat: refresh converter interfaces #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f426234
feat: refresh converter interfaces
ianbotsf Nov 14, 2025
7f65a5d
lint
ianbotsf Nov 17, 2025
2af278e
Feedback from code review: renaming the *MappingConverter.kt files to…
ianbotsf Nov 18, 2025
987afc0
apiDump
ianbotsf Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 53 additions & 53 deletions ...er-codegen/src/main/kotlin/aws/sdk/kotlin/hll/dynamodbmapper/codegen/model/MapperTypes.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,69 +84,69 @@ public object MapperTypes {
public object Values {
public fun valueConverter(value: Type): TypeRef = TypeRef(MapperPkg.Hl.Values, "ValueConverter", genericArgs = listOf(value))
public val ItemToValueConverter: TypeRef = TypeRef(MapperPkg.Hl.Values, "ItemToValueConverter")
public val NullableConverter: TypeRef = TypeRef(MapperPkg.Hl.Values, "NullableConverter")
public val NullableValueConverter: TypeRef = TypeRef(MapperPkg.Hl.Values, "NullableValueConverter")

public object Collections {
public val ListConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "ListConverter")
public val MapConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "MapConverter")

public val StringSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "StringSetConverter")
public val CharSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "CharSetConverter")
public val CharArraySetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "CharArraySetConverter")

public val ByteSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "ByteSetConverter")
public val DoubleSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "DoubleSetConverter")
public val FloatSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "FloatSetConverter")
public val IntSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "IntSetConverter")
public val LongSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "LongSetConverter")
public val ShortSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "ShortSetConverter")

public val UByteSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "UByteSetConverter")
public val UIntSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "UIntSetConverter")
public val ULongSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "ULongSetConverter")
public val UShortSetConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "UShortSetConverter")
public val ListValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "ListValueConverter")
public val MapValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "MapValueConverter")

public val StringSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "StringSetValueConverter")
public val CharSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "CharSetValueConverter")
public val CharArraySetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "CharArraySetValueConverter")

public val ByteSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.Byte")
public val DoubleSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.Double")
public val FloatSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.Float")
public val IntSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.Int")
public val LongSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.Long")
public val ShortSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.Short")

public val UByteSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.UByte")
public val UIntSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.UInt")
public val ULongSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.ULong")
public val UShortSetValueConverter: TypeRef = TypeRef(MapperPkg.Hl.CollectionValues, "NumberSetValueConverters.UShort")
}

public object Scalars {
public fun enumConverter(enumType: Type): TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "EnumConverter", genericArgs = listOf(enumType))

public val BooleanConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "BooleanConverter")
public val StringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "StringConverter")
public val CharConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "CharConverter")
public val CharArrayConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "CharArrayConverter")

public val ByteConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "ByteConverter")
public val ByteArrayConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "ByteArrayConverter")
public val DoubleConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "DoubleConverter")
public val FloatConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "FloatConverter")
public val IntConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "IntConverter")
public val LongConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "LongConverter")
public val ShortConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "ShortConverter")
public val UByteConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "UByteConverter")
public val UIntConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "UIntConverter")
public val ULongConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "ULongConverter")
public val UShortConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "UShortConverter")
public fun enumValueConverter(enumType: Type): TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "EnumValueConverter", genericArgs = listOf(enumType))

public val BooleanValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "BooleanValueConverter")
public val ByteArrayValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "ByteArrayValueConverter")
public val StringValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "StringValueConverter")
public val CharValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "CharValueConverter")
public val CharArrayValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "CharArrayValueConverter")

public val ByteValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.Byte")
public val DoubleValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.Double")
public val FloatValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.Float")
public val IntValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.Int")
public val LongValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.Long")
public val ShortValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.Short")
public val UByteValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.UByte")
public val UIntValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.UInt")
public val ULongValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.ULong")
public val UShortValueConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberValueConverters.UShort")

public val BooleanToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "BooleanToStringConverter")
public val CharArrayToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "TextConverters.CharArrayToStringConverter")
public val CharToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "TextConverters.CharToStringConverter")
public val StringToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "TextConverters.StringToStringConverter")
public val ByteToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.ByteToStringConverter")
public val DoubleToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.DoubleToStringConverter")
public val FloatToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.FloatToStringConverter")
public val IntToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.IntToStringConverter")
public val LongToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.LongToStringConverter")
public val ShortToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.ShortToStringConverter")
public val UByteToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.UByteToStringConverter")
public val UIntToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.UIntToStringConverter")
public val ULongToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.ULongToStringConverter")
public val UShortToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberConverters.UShortToStringConverter")
public val CharArrayToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "TextConverters.CharArrayToString")
public val CharToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "TextConverters.CharToString")
public val StringToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "TextConverters.String")
public val ByteToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.Byte")
public val DoubleToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.Double")
public val FloatToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.Float")
public val IntToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.Int")
public val LongToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.Long")
public val ShortToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.Short")
public val UByteToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.UByte")
public val UIntToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.UInt")
public val ULongToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.ULong")
public val UShortToStringConverter: TypeRef = TypeRef(MapperPkg.Hl.ScalarValues, "NumberToStringConverters.UShort")
}

public object SmithyTypes {
public val DefaultInstantConverter: TypeRef = TypeRef(MapperPkg.Hl.SmithyTypeValues, "InstantConverter.Default")
public val UrlConverter: TypeRef = TypeRef(MapperPkg.Hl.SmithyTypeValues, "UrlConverter")
public val DefaultDocumentConverter: TypeRef = TypeRef(MapperPkg.Hl.SmithyTypeValues, "DocumentConverter.Default")
public val DefaultInstantValueConverter: TypeRef = TypeRef(MapperPkg.Hl.SmithyTypeValues, "InstantValueConverter.Default")
public val UrlValueConverter: TypeRef = TypeRef(MapperPkg.Hl.SmithyTypeValues, "UrlValueConverter")
public val DefaultDocumentValueConverter: TypeRef = TypeRef(MapperPkg.Hl.SmithyTypeValues, "DocumentValueConverter.Default")
}
}

Expand Down
10 changes: 5 additions & 5 deletions ...otlin/aws/sdk/kotlin/hll/dynamodbmapper/codegen/operations/rendering/OperationRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,17 @@ internal class OperationRenderer(
requestMembers(MemberCodegenBehavior.PassThrough) { write("#L = this@convert.#L", name, highLevel.name) }
requestMembers(MemberCodegenBehavior.MapKeys) {
write(
"this@convert.#L?.let { #L = schema.converter.convertTo(it, schema.keyAttributeNames).#T(schema.keyAttributeNames) }",
"this@convert.#L?.let { #L = schema.converter.convertRight(it).#T(schema.keyAttributeNames) }",
highLevel.name,
name,
MapperTypes.Model.intersectKeys,
)
}
requestMembers(MemberCodegenBehavior.MapAll) {
write("this@convert.#L?.let { #L = schema.converter.convertTo(it) }", highLevel.name, name)
write("this@convert.#L?.let { #L = schema.converter.convertRight(it) }", highLevel.name, name)
}
requestMembers(MemberCodegenBehavior.ListMapAll) {
write("#L = this@convert.#L?.map { schema.converter.convertTo(it) }", name, highLevel.name)
write("#L = this@convert.#L?.map { schema.converter.convertRight(it) }", name, highLevel.name)
}
requestMembers(MemberCodegenBehavior.Hoist) { write("this.#1L = #1L", name) }

Expand Down Expand Up @@ -168,7 +168,7 @@ internal class OperationRenderer(

responseMembers(MemberCodegenBehavior.MapKeys, MemberCodegenBehavior.MapAll) {
write(
"#L = this@convert.#L?.#T()?.let(schema.converter::convertFrom)",
"#L = this@convert.#L?.#T()?.let(schema.converter::convertLeft)",
highLevel.name,
name,
MapperTypes.Model.toItem,
Expand All @@ -177,7 +177,7 @@ internal class OperationRenderer(

responseMembers(MemberCodegenBehavior.ListMapAll) {
write(
"#L = this@convert.#L?.map { schema.converter.convertFrom(it.#T()) }",
"#L = this@convert.#L?.map { schema.converter.convertLeft(it.#T()) }",
highLevel.name,
name,
MapperTypes.Model.toItem,
Expand Down
Loading
Loading