-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix extended_material_bindless example wgpu validation error on MacOS/Metal #21729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 8 commits into
bevyengine:main
from
NicoZweifel:fix-metal-extended-bindless-wgpu-validation-error
Dec 3, 2025
Merged
Fix extended_material_bindless example wgpu validation error on MacOS/Metal #21729
alice-i-cecile
merged 8 commits into
bevyengine:main
from
NicoZweifel:fix-metal-extended-bindless-wgpu-validation-error
Dec 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bindless-wgpu-validation-error
IceSentry
approved these changes
Nov 3, 2025
robtfm
approved these changes
Nov 3, 2025
mgi388
approved these changes
Dec 1, 2025
Contributor
mgi388
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there are already approvals, but I tested on my Macbook Pro and it fixes the bug for me so leaving another approval.
INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "macOS 15.7.2 Sequoia", kernel: "24.6.0", cpu: "Apple M1 Max", core_count: "10", memory: "64.0 GiB" }
INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
INFO bevy_render::batching::gpu_preprocessing: GPU preprocessing is fully supported on this device.
I ran these examples (added the last 2 just because I tested them but I don't think they'd be affected anyway):
cargo run --example extended_material_bindless
cargo run --example extended_material
cargo run --example texture_binding_array
cargo run --example storage_buffer
cargo run --example array_texture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
C-Examples
An addition or correction to our examples
O-MacOS
Specific to the MacOS (Apple) desktop operating system
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
bindless_supportedof theAsBindGrouptrait forExtendedMaterial:Before it just returned the default (true), leading to the mismatch.
I made small, mostly stylistic, improvements to
fn bind_group_layout_entriesand a few other locations like a comment inextended_materialduring debugging but I could move that out into a separate PR as well. Since the changes are rather limited and related to the issue I decided to leave it in for now.Testing
extended_material_bindlessandextended_materialexamples.