-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Added error message, and added check for empty strings in parse_internal #21762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DylanD42
wants to merge
1
commit into
bevyengine:main
Choose a base branch
from
DylanD42:DylanBranch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| use bevy::prelude::*; | ||
| use bevy::asset::LoadState; | ||
|
|
||
| #[test] | ||
| fn test_asset_load_valid_file() { | ||
| let mut app = App::new(); | ||
| app.add_plugins(MinimalPlugins) | ||
| .add_plugins(AssetPlugin::default()) | ||
| .init_asset::<Image>(); | ||
|
|
||
| let asset_server = app.world().resource::<AssetServer>(); | ||
| let handle: Handle<Image> = asset_server.load("branding/bevy_bird_dark.png"); | ||
|
|
||
| // Confirm the asset exists in Bevy's registry | ||
| let state = asset_server.get_load_state(handle.id()); | ||
| assert!( | ||
| matches!(state, Some(LoadState::NotLoaded) | Some(LoadState::Loading) | Some(LoadState::Loaded)), | ||
| "Valid file should be in a valid load state, got {:?}", | ||
| state | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_asset_load_invalid_file() { | ||
| let mut app = App::new(); | ||
| app.add_plugins(MinimalPlugins) | ||
| .add_plugins(AssetPlugin::default()) | ||
| .init_asset::<Image>(); | ||
|
|
||
| let asset_server = app.world().resource::<AssetServer>(); | ||
|
|
||
| // Bevy doesn't panic on invalid paths - it creates a handle and marks it as failed | ||
| let handle: Handle<Image> = asset_server.load("nonexistent/fake_file.png"); | ||
|
|
||
| // The handle should be created successfully (no panic) | ||
| let state = asset_server.get_load_state(handle.id()); | ||
|
|
||
| // We just verify that a handle was created - Bevy will handle the error internally | ||
| assert!( | ||
| state.is_some(), | ||
| "Invalid file should still create a handle, got {:?}", | ||
| state | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| #[should_panic] | ||
| fn test_asset_load_empty_path_panics() { | ||
| let mut app = App::new(); | ||
| app.add_plugins(MinimalPlugins) | ||
| .add_plugins(AssetPlugin::default()) | ||
| .init_asset::<Image>(); | ||
|
|
||
| let asset_server = app.world().resource::<AssetServer>(); | ||
|
|
||
| // Test that load panics with empty string | ||
| let _handle: Handle<Image> = asset_server.load(""); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bevy_asset/src/lib.rsalready contains a bunch of tests, which you could use as examples. It might be better to just add a new test there rather than start something new here (especially since those tests already have a bunch of utilities for writing tests more conveniently).