Skip to content

Conversation

@lucia-w
Copy link
Contributor

@lucia-w lucia-w commented Nov 8, 2025

  • ReadAllHashesInRange pre-allocates the result slice with make([]*NumberHash, 0, 1+last-first) while first/last are uint64. If the caller passes an inverted range, it could cause the node to panic.

@lucia-w lucia-w requested a review from rjl493456442 as a code owner November 8, 2025 01:30
@gballet gballet self-assigned this Nov 8, 2025
@gballet
Copy link
Member

gballet commented Nov 13, 2025

Hi, thanks a lot for your contribution! 🙏
At the moment, the go-ethereum team is overloaded with pull requests and in order to ensure we can give high quality review and attention to critical changes, we are not accepting refactoring-only PRs or minor upgrades.

We really appreciate the effort and encourage you to keep contributing, but for now we need to focus our limited review bandwidth on feature work, bug fixes, and protocol changes.

Thanks for understanding!

@gballet gballet closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants