Skip to content

core: prevent integer underflow in ReadAllHashesInRange #33126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

core: prevent integer underflow in ReadAllHashesInRange #33126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion core/rawdb/accessors_chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"bytes"
"encoding/binary"
"fmt"
"math"
"math/big"
"slices"

Expand Down Expand Up @@ -87,10 +88,21 @@ type NumberHash struct {
// heights, both canonical and reorged forks included.
// This method considers both limits to be _inclusive_.
func ReadAllHashesInRange(db ethdb.Iteratee, first, last uint64) []*NumberHash {
// Return empty result for inverted ranges
if last < first {
return nil
}
rangeLen := last - first
var capHint int
if rangeLen >= uint64(math.MaxInt) {
capHint = math.MaxInt
} else {
capHint = int(rangeLen) + 1
}
var (
start = encodeBlockNumber(first)
keyLength = len(headerPrefix) + 8 + 32
hashes = make([]*NumberHash, 0, 1+last-first)
hashes = make([]*NumberHash, 0, capHint)
it = db.NewIterator(headerPrefix, start)
)
defer it.Release()
Expand Down