-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Firebase AI] Add Sendable conformance to PartsRepresentable
#15199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds Sendable conformance to the PartsRepresentable protocol and adds the necessary conditional retroactive Sendable conformance for CGImage, NSImage, and CIImage to support older Swift versions. However, the changes introduce compilation errors by removing the public access modifier from the partsValue property in the extensions for these image types. Since PartsRepresentable is a public protocol, its requirements must be implemented with public visibility. My review includes suggestions to fix this.
| @available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *) | ||
| extension NSImage: PartsRepresentable {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This produces the warning Conformance of 'NSImage' to 'Sendable' is only available in macOS 14.0 or newer on Xcode 26.1 (and potentially other versions of 26).
Require
Sendableconformance forPartsRepresentabletypes.Note:
CGImagedidn't becomeSendableuntil Swift 6.1 (Xcode 16.3) andNSImage/CIImagebecameSendablein Swift 6.2 (Xcode 26.0). As a workaround, these types are marked@unchecked @retroactive Sendableto support building on Xcode 16.0 to 16.2.#no-changelog