Skip to content

[Firebase AI] Add Sendable conformance to PartsRepresentable #15199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+35 −8
Draft

[Firebase AI] Add Sendable conformance to PartsRepresentable #15199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88e16fb
[Firebase AI] Add `Sendable` conformance to `PartsRepresentable`
andrewheard Aug 14, 2025
ffdf538
Try workaround for `Sendable` on Xcode 16.2
andrewheard Aug 14, 2025
ebad68e
Merge branch 'main' into ah/ai-partsrep-sendable
andrewheard Aug 18, 2025
9febee3
Merge remote-tracking branch 'origin/main' into ah/ai-partsrep-sendable
andrewheard Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions FirebaseAI/Sources/PartsRepresentable+Image.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ enum ImageConversionError: Error {
#elseif canImport(AppKit)
/// Enables images to be representable as ``PartsRepresentable``.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
extension NSImage: PartsRepresentable {
public var partsValue: [any Part] {
public extension NSImage {
var partsValue: [any Part] {
guard let cgImage = cgImage(forProposedRect: nil, context: nil, hints: nil) else {
return [ErrorPart(ImageConversionError.invalidUnderlyingImage)]
}
Expand All @@ -63,13 +63,22 @@ enum ImageConversionError: Error {
return [InlineDataPart(data: data, mimeType: "image/jpeg")]
}
}
#endif

#if swift(>=6.2)
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
extension NSImage: PartsRepresentable {}
Comment on lines +68 to +69
Copy link
Contributor Author

@andrewheard andrewheard Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces the warning Conformance of 'NSImage' to 'Sendable' is only available in macOS 14.0 or newer on Xcode 26.1 (and potentially other versions of 26).

#else // swift(>=6.2)
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
extension NSImage: @unchecked @retroactive Sendable, PartsRepresentable {}
#endif

#endif // canImport(UIKit)

#if !os(watchOS) // This code does not build on watchOS.
/// Enables `CGImages` to be representable as model content.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, *)
extension CGImage: PartsRepresentable {
public var partsValue: [any Part] {
public extension CGImage {
var partsValue: [any Part] {
let output = NSMutableData()
guard let imageDestination = CGImageDestinationCreateWithData(
output, UTType.jpeg.identifier as CFString, 1, nil
Expand All @@ -86,13 +95,22 @@ enum ImageConversionError: Error {
return [ErrorPart(ImageConversionError.couldNotConvertToJPEG)]
}
}

#if swift(>=6.1)
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, *)
extension CGImage: PartsRepresentable {}
#else // swift(>=6.1)
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, *)
extension CGImage: @unchecked @retroactive Sendable, PartsRepresentable {}
#endif // swift(>=6.1)

#endif // !os(watchOS)

#if canImport(CoreImage)
/// Enables `CIImages` to be representable as model content.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, *)
extension CIImage: PartsRepresentable {
public var partsValue: [any Part] {
public extension CIImage {
var partsValue: [any Part] {
let context = CIContext()
let jpegData = (colorSpace ?? CGColorSpace(name: CGColorSpace.sRGB))
.flatMap {
Expand All @@ -107,4 +125,13 @@ enum ImageConversionError: Error {
return [ErrorPart(ImageConversionError.couldNotConvertToJPEG)]
}
}

#if swift(>=6.2)
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, *)
extension CIImage: PartsRepresentable {}
#else // swift(>=6.2)
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, *)
extension CIImage: @unchecked @retroactive Sendable, PartsRepresentable {}
#endif // swift(>=6.2)

#endif // canImport(CoreImage)
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/PartsRepresentable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Foundation
/// A protocol describing any data that could be serialized to model-interpretable input data,
/// where the serialization process cannot fail with an error.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
public protocol PartsRepresentable {
public protocol PartsRepresentable: Sendable {
var partsValue: [any Part] { get }
}

Expand Down
Loading