Skip to content

chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 13, 2025
Merged

chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 #5359

merged 25 commits into from
Nov 13, 2025

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5356

📜 Description

Bump MacOS sample to macos 12.0 which is the minimum for v9

💡 Motivation and Context

Failed tests and MacOS version bump in the Apple SDK

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

itaybre and others added 22 commits September 8, 2025 15:27
@itaybre
fix: Fixes SentryScreenFrames use after being converted to Swift
686b6f8
@itaybre
Merge branch 'main' into itay/fix_sentreyscreenframes
07104dd
@itaybre
Fix build
5a09e8e
@antonis
Merge branch 'main' into itay/fix_sentreyscreenframes
347a601
@denrase
Use non-experimental enableLogs
7577a17
@denrase
bump target
d3fe306
@denrase
remove enable tracing
3bd04c2
@denrase
Update enableLogs tests
cc596a8
@antonis
Merge branch 'main' into itay/fix_sentreyscreenframes
2b4c1d4
@itaybre
chore: Fix RNSentry after SentryFramesTracker conversion to swift
d99584c
@itaybre
Run linter
ca44d59
@noahsmartin
Remove unused debug image provider imports
4c0fb34
@noahsmartin
Remove imports
d61ca6d
@noahsmartin
chore: Remove deprecated user property
6a25cb9
@noahsmartin
chore: Remove use of deprecate integrations API (#5304)
1bda802
@noahsmartin
Remove use of integrations in tests
0327771
@noahsmartin
chore: Remove use of deprecated prop (#5322)
80af135
@noahsmartin
ref: Move options to wrapper
b407fd2
@antonis
Merge branch 'cocoa-v9' into itay/fix_sentreyscreenframes
914e943 
# Conflicts:
#	packages/core/ios/RNSentry.mm
@antonis
Merge branch 'itay/fix_sentreyscreenframes' into denrase/options-enab…
7633931 
…le-logs
@antonis
Merge branch 'denrase/options-enable-logs' into itay/frames_tracker_s…
076a651 
…wift

# Conflicts:
#	packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj
#	packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m
#	packages/core/ios/RNSentry.mm
#	packages/core/ios/RNSentryDependencyContainer.m
#	packages/core/ios/SentrySDKWrapper.h
#	packages/core/ios/SentrySDKWrapper.m
@antonis
chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum fo…
a818d2b 
…r v9
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis antonis mentioned this pull request Nov 11, 2025
Draft
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.06 ms 1214.26 ms 0.19 ms
Size 3.41 MiB 4.63 MiB 1.21 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.74 ms 416.26 ms 30.52 ms
Size 43.75 MiB 48.02 MiB 4.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.50 ms 1212.06 ms -3.44 ms
Size 3.41 MiB 4.63 MiB 1.21 MiB

Base automatically changed from itay/frames_tracker_swift to cocoa-v9 November 11, 2025 15:41
@antonis antonis marked this pull request as ready for review November 11, 2025 15:42
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025 •
edited
Loading

The two failing/canceled tests seem to be irelevant with this PR and will be handled separately:

I believe they might be related to a recent macos-13 runner deprecation

@antonis antonis changed the title chore(sample): Bump MacOS sample to macos 12.0 chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.85 ms 396.18 ms 26.33 ms
Size 43.94 MiB 48.85 MiB 4.91 MiB

This was referenced Nov 11, 2025
Merged
Merged
@antonis
Copy link
Contributor Author

antonis commented Nov 12, 2025

The following will be handled with #5369

@antonis antonis mentioned this pull request Nov 12, 2025
Merged
10 tasks
@antonis antonis merged commit 8aea859 into cocoa-v9 Nov 13, 2025
66 of 68 checks passed
@antonis antonis deleted the antonis/cocoa-v9-macos-v12-bump branch November 13, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx Awaiting requested review from alwx alwx is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@antonis @itaybre @denrase @noahsmartin