Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 12, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5356 < #5359

📜 Description

Bump iOS foe E2E sample to 15.1 since:

💡 Motivation and Context

Failed RN 0.71.11 tests and iOS version bump in the Apple SDK

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

itaybre and others added 26 commits September 8, 2025 15:27
# Conflicts:
#	packages/core/ios/RNSentry.mm
…wift

# Conflicts:
#	packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj
#	packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m
#	packages/core/ios/RNSentry.mm
#	packages/core/ios/RNSentryDependencyContainer.m
#	packages/core/ios/SentrySDKWrapper.h
#	packages/core/ios/SentrySDKWrapper.m
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 12, 2025
@antonis antonis changed the base branch from cocoa-v9 to antonis/cocoa-v9-macos-v12-bump November 12, 2025 13:33
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 481.15 ms 505.54 ms 24.39 ms
Size 43.75 MiB 48.02 MiB 4.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.81 ms 405.70 ms 12.89 ms
Size 43.94 MiB 48.85 MiB 4.91 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.02 ms 1217.76 ms 8.74 ms
Size 3.41 MiB 4.64 MiB 1.22 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.04 ms 1216.92 ms 1.87 ms
Size 3.41 MiB 4.64 MiB 1.22 MiB


if (currentMatch) {
const currentValue = currentMatch[1];
const shouldPatchVersion = currentValue === 'min_ios_version_supported' ||
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity since the RN requirement (15.1) is close to the Cocoa one (15.0) , I force the specified version instead of fetching the min_ios_version_supported and comparing.

@antonis
Copy link
Contributor Author

antonis commented Nov 12, 2025

The Maestro test for feedback is consistently failing on 0.81.0 with

feedbackElement not found: Id matching regex: sentry-feedback-email-input)

I plan to revisit this with a follow up PR for Cocoa v9.

@antonis antonis marked this pull request as ready for review November 12, 2025 16:11
Base automatically changed from antonis/cocoa-v9-macos-v12-bump to cocoa-v9 November 13, 2025 11:00
@antonis antonis merged commit c2a73eb into cocoa-v9 Nov 13, 2025
11 checks passed
@antonis antonis deleted the antonis/cocoa-v9-min-iOS15 branch November 13, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants