Skip to content

Conversation

@pwilkin
Copy link
Collaborator

@pwilkin pwilkin commented Nov 9, 2025

From the creators of the horror show "llama-model.cpp - refactoring" comes the sequel: "convert_hf_to_gguf.py - refactoring".

Still in draft because it's not all finished, but I thought that if someone wanted to chime in I'll put it up already.

@CISC
Copy link
Collaborator

CISC commented Nov 9, 2025

🤯 Looks like a decent enough plan though. Only downside is that there will no longer just be a single script to grab and run, but that has been a source of error and confusion anyway.

You should derive _MODEL_MODULES from models_map.

@CISC
Copy link
Collaborator

CISC commented Nov 9, 2025

@compilade Your input would be much appreciated as well.

@CISC CISC added the refactoring Refactoring label Nov 9, 2025
}
if name not in model_map:
raise ValueError(f"Unknown model class: {name}")
module_name, class_name = model_map[name]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the class_name seems to always be equal to name, would it make sense to lighten the model_map to avoid having to write the class name twice every time?

@compilade
Copy link
Collaborator

(note for later) This will (trivially) conflict with at least

@CISC
Copy link
Collaborator

CISC commented Nov 9, 2025

Are you expecting more work on these? Can be merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants