-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Refactor: convert_hf_to_gguf.py #17114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🤯 Looks like a decent enough plan though. Only downside is that there will no longer just be a single script to grab and run, but that has been a source of error and confusion anyway. You should derive |
|
@compilade Your input would be much appreciated as well. |
| } | ||
| if name not in model_map: | ||
| raise ValueError(f"Unknown model class: {name}") | ||
| module_name, class_name = model_map[name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the class_name seems to always be equal to name, would it make sense to lighten the model_map to avoid having to write the class name twice every time?
|
(note for later) This will (trivially) conflict with at least
|
|
Are you expecting more work on these? Can be merged now. |
From the creators of the horror show "llama-model.cpp - refactoring" comes the sequel: "convert_hf_to_gguf.py - refactoring".
Still in draft because it's not all finished, but I thought that if someone wanted to chime in I'll put it up already.