-
-
Notifications
You must be signed in to change notification settings - Fork 1
breaking: drop node v18 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request upgrades the minimum Node.js runtime version from 18 to 20 across CI workflows and package configuration. It also declares pnpm as the package manager with a specific version and integrity hash in package.json. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci.yml(4 hunks).github/workflows/release.yml(1 hunks)package.json(2 hunks)
🔇 Additional comments (3)
.github/workflows/release.yml (1)
34-34: Node.js version bump is consistent and correct.The change from Node 18 to Node 20 aligns with the PR objective and matches the CI workflow updates.
package.json (1)
29-29: Engine requirement updated correctly.The minimum Node.js requirement is now aligned with the PR objective of dropping Node v18 support.
.github/workflows/ci.yml (1)
39-39: Node.js matrix versions updated consistently across all CI jobs.All workflow jobs (build, test, e2e, edge-release) now test only against Node 20, which aligns with the updated engine requirement in package.json.
Also applies to: 74-74, 114-114, 185-185
| "vitest-environment-miniflare": "^2.14.1" | ||
| } | ||
| }, | ||
| "packageManager": "pnpm@9.5.0+sha512.140036830124618d624a2187b50d04289d5a087f326c9edfc0ccd733d76c4f52c3a313d4fc148794a2a9d81553016004e6742e8cf850670268a7387fc220c903" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify the pnpm packageManager integrity hash.
The packageManager field declaration with integrity hash is a good practice for reproducibility, but the hash should be validated to ensure it matches the declared pnpm version.
🏁 Script executed:
#!/bin/bash
# Description: Verify pnpm@9.5.0 integrity hash and search for other Node version configs
# Fetch pnpm@9.5.0 tarball metadata from npm registry
echo "=== Checking pnpm@9.5.0 metadata from npm registry ==="
curl -s https://registry.npmjs.org/pnpm/9.5.0 | jq '.dist | {version, shasum, integrity}'
# Search for other Node version configuration files
echo ""
echo "=== Searching for other Node version configuration files ==="
fd -e nvmrc -e tool-versions -e .node-version 2>/dev/null || echo "No .nvmrc, .tool-versions, or .node-version files found"Length of output: 308
Fix the pnpm packageManager integrity hash.
The integrity hash in package.json does not match the official pnpm@9.5.0 release from npm registry:
- Registry hash:
sha512-FAA2gwEkYY1iSiGHtQ0EKJ1aCH8ybJ7fwMzXM9dsT1LDoxPU/BSHlKKp2BVTAWAE5nQujPhQZwJopzh/wiDJAw== - Declared hash:
sha512.140036830124618d624a2187b50d04289d5a087f326c9edfc0ccd733d76c4f52c3a313d4fc148794a2a9d81553016004e6742e8cf850670268a7387fc220c903
Update the hash to match the registry to ensure reproducibility and prevent unexpected version mismatches.
🤖 Prompt for AI Agents
In package.json around line 129, the packageManager integrity hash for
pnpm@9.5.0 is incorrect; replace the current value after the "+" with the
official registry integrity string so the entry reads
pnpm@9.5.0+sha512-FAA2gwEkYY1iSiGHtQ0EKJ1aCH8ybJ7fwMzXM9dsT1LDoxPU/BSHlKKp2BVTAWAE5nQujPhQZwJopzh/wiDJAw==,
ensuring the file uses the exact registry hash to guarantee reproducible
installs.
Description
Linked Issues
Additional context
Summary by CodeRabbit