Skip to content

breaking: drop node v18 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

breaking: drop node v18 #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [18.x]
node: [20]

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [18.x]
node: [20]

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [18.x]
node: [20]

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -182,7 +182,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [18]
node: [20]
steps:
- name: Checkout codes
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: Enable corepack
run: corepack enable
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"access": "public"
},
"engines": {
"node": ">= 18"
"node": ">= 20"
},
"type": "module",
"sideEffects": false,
Expand Down Expand Up @@ -125,5 +125,6 @@
"unbuild": "^2.0.0",
"vitest": "^1.3.0",
"vitest-environment-miniflare": "^2.14.1"
}
},
"packageManager": "pnpm@9.5.0+sha512.140036830124618d624a2187b50d04289d5a087f326c9edfc0ccd733d76c4f52c3a313d4fc148794a2a9d81553016004e6742e8cf850670268a7387fc220c903"
Copy link

@coderabbitai coderabbitai bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify the pnpm packageManager integrity hash.

The packageManager field declaration with integrity hash is a good practice for reproducibility, but the hash should be validated to ensure it matches the declared pnpm version.

🏁 Script executed:

#!/bin/bash
# Description: Verify pnpm@9.5.0 integrity hash and search for other Node version configs

# Fetch pnpm@9.5.0 tarball metadata from npm registry
echo "=== Checking pnpm@9.5.0 metadata from npm registry ==="
curl -s https://registry.npmjs.org/pnpm/9.5.0 | jq '.dist | {version, shasum, integrity}'

# Search for other Node version configuration files
echo ""
echo "=== Searching for other Node version configuration files ==="
fd -e nvmrc -e tool-versions -e .node-version 2>/dev/null || echo "No .nvmrc, .tool-versions, or .node-version files found"

Length of output: 308

Fix the pnpm packageManager integrity hash.

The integrity hash in package.json does not match the official pnpm@9.5.0 release from npm registry:

  • Registry hash: sha512-FAA2gwEkYY1iSiGHtQ0EKJ1aCH8ybJ7fwMzXM9dsT1LDoxPU/BSHlKKp2BVTAWAE5nQujPhQZwJopzh/wiDJAw==
  • Declared hash: sha512.140036830124618d624a2187b50d04289d5a087f326c9edfc0ccd733d76c4f52c3a313d4fc148794a2a9d81553016004e6742e8cf850670268a7387fc220c903

Update the hash to match the registry to ensure reproducibility and prevent unexpected version mismatches.

🤖 Prompt for AI Agents 
In package.json around line 129, the packageManager integrity hash for
pnpm@9.5.0 is incorrect; replace the current value after the "+" with the
official registry integrity string so the entry reads
pnpm@9.5.0+sha512-FAA2gwEkYY1iSiGHtQ0EKJ1aCH8ybJ7fwMzXM9dsT1LDoxPU/BSHlKKp2BVTAWAE5nQujPhQZwJopzh/wiDJAw==,
ensuring the file uses the exact registry hash to guarantee reproducible
installs.

}