Remove valid case for additionalItems validation #795
+0
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed valid test case for additionalItems schema validation.
jdesrosiers
requested changes
Nov 25, 2025
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Thanks for picking this us. Please make the change for the other drafts as well.
Removed a valid test case for additionalItems schema validation.
Removed test case for additionalItems not looking in applicators.
Removed a valid test case for additionalItems schema validation.
Removed a valid test case for additionalItems schema validation.
Removed test case for additionalProperties not examining applicators.
Removed test case for additionalProperties not considering applicators.
Author
|
I’ve updated all drafts and removed the corresponding test cases as requested. |
jdesrosiers
requested changes
Nov 26, 2025
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
You can undo the changes in 2020-12 and v1. Those are a different tests for additionalProperties, not additionalItems. additionalItems was removed in 2020-12, so this test doesn't appear after that.
Author
|
Reverted the incorrect removals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed valid test case for additionalItems schema validation.
Fixes #768