Skip to content

Remove valid case for additionalItems validation #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+0 −81
Open

Remove valid case for additionalItems validation #795

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da4a568
Remove valid case for additionalItems validation
anmolbhadoriya5849 Nov 24, 2025
f348888
Remove valid test case for additionalItems
anmolbhadoriya5849 Nov 25, 2025
8ba9635
Remove test for additionalItems applicators
anmolbhadoriya5849 Nov 25, 2025
a3feff7
Remove valid case for additionalItems validation
anmolbhadoriya5849 Nov 25, 2025
756eebd
Remove valid case for additionalItems validation
anmolbhadoriya5849 Nov 25, 2025
0d54c82
Remove test for additionalProperties behavior
anmolbhadoriya5849 Nov 25, 2025
df833be
Remove test case for additionalProperties behavior
anmolbhadoriya5849 Nov 25, 2025
b4032b9
Revert removal of additionalProperties applicator tests in draft2020-12
anmolbhadoriya5849 Nov 26, 2025
232f079
Revert removal of additionalProperties applicator tests in v1
anmolbhadoriya5849 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions tests/draft2019-09/additionalItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,23 +127,6 @@
}
]
},
{
"description": "additionalItems does not look in applicators, valid case",
"schema": {
"$schema": "https://json-schema.org/draft/2019-09/schema",
"allOf": [
{ "items": [ { "type": "integer" } ] }
],
"additionalItems": { "type": "boolean" }
},
"tests": [
{
"description": "items defined in allOf are not examined",
"data": [ 1, null ],
"valid": true
}
]
},
{
"description": "additionalItems does not look in applicators, invalid case",
"schema": {
Expand Down
18 changes: 0 additions & 18 deletions tests/draft2020-12/additionalProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"description":
"additionalProperties being false does not allow other properties",
"specification": [ { "core":"10.3.2.3", "quote": "The value of \"additionalProperties\" MUST be a valid JSON Schema. Boolean \"false\" forbids everything." } ],

Check notice on line 5 in tests/draft2020-12/additionalProperties.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-01#section-10.3.2.3
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"properties": {"foo": {}, "bar": {}},
Expand Down Expand Up @@ -44,7 +44,7 @@
},
{
"description": "non-ASCII pattern with additionalProperties",
"specification": [ { "core":"10.3.2.3"} ],

Check notice on line 47 in tests/draft2020-12/additionalProperties.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-01#section-10.3.2.3
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"patternProperties": {"^á": {}},
Expand All @@ -65,7 +65,7 @@
},
{
"description": "additionalProperties with schema",
"specification": [ { "core":"10.3.2.3", "quote": "The value of \"additionalProperties\" MUST be a valid JSON Schema." } ],

Check notice on line 68 in tests/draft2020-12/additionalProperties.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-01#section-10.3.2.3
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"properties": {"foo": {}, "bar": {}},
Expand All @@ -91,7 +91,7 @@
},
{
"description": "additionalProperties can exist by itself",
"specification": [ { "core":"10.3.2.3", "quote": "With no other applicator applying to object instances. This validates all the instance values irrespective of their property names" } ],

Check notice on line 94 in tests/draft2020-12/additionalProperties.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-01#section-10.3.2.3
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": {"type": "boolean"}
Expand All @@ -111,7 +111,7 @@
},
{
"description": "additionalProperties are allowed by default",
"specification": [ { "core":"10.3.2.3", "quote": "Omitting this keyword has the same assertion behavior as an empty schema." } ],

Check notice on line 114 in tests/draft2020-12/additionalProperties.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-01#section-10.3.2.3
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"properties": {"foo": {}, "bar": {}}
Expand All @@ -124,27 +124,9 @@
}
]
},
{
"description": "additionalProperties does not look in applicators",
"specification":[ { "core": "10.2", "quote": "Subschemas of applicator keywords evaluate the instance completely independently such that the results of one such subschema MUST NOT impact the results of sibling subschemas." } ],
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"allOf": [
{"properties": {"foo": {}}}
],
"additionalProperties": {"type": "boolean"}
},
"tests": [
{
"description": "properties defined in allOf are not examined",
"data": {"foo": 1, "bar": true},
"valid": false
}
]
},
{
"description": "additionalProperties with null valued instance properties",
"specification": [ { "core":"10.3.2.3" } ],

Check notice on line 129 in tests/draft2020-12/additionalProperties.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-01#section-10.3.2.3
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"additionalProperties": {
Expand Down
16 changes: 0 additions & 16 deletions tests/draft3/additionalItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,22 +94,6 @@
}
]
},
{
"description": "additionalItems does not look in applicators",
"schema": {
"extends": [
{ "items": [ { "type": "integer" } ] }
],
"additionalItems": { "type": "boolean" }
},
"tests": [
{
"description": "items defined in extends are not examined",
"data": [ 1, null ],
"valid": true
}
]
},
{
"description": "additionalItems with heterogeneous array",
"schema": {
Expand Down
16 changes: 0 additions & 16 deletions tests/draft4/additionalItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,22 +94,6 @@
}
]
},
{
"description": "additionalItems does not look in applicators, valid case",
"schema": {
"allOf": [
{ "items": [ { "type": "integer" } ] }
],
"additionalItems": { "type": "boolean" }
},
"tests": [
{
"description": "items defined in allOf are not examined",
"data": [ 1, null ],
"valid": true
}
]
},
{
"description": "additionalItems does not look in applicators, invalid case",
"schema": {
Expand Down
16 changes: 0 additions & 16 deletions tests/draft6/additionalItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,22 +117,6 @@
}
]
},
{
"description": "additionalItems does not look in applicators, valid case",
"schema": {
"allOf": [
{ "items": [ { "type": "integer" } ] }
],
"additionalItems": { "type": "boolean" }
},
"tests": [
{
"description": "items defined in allOf are not examined",
"data": [ 1, null ],
"valid": true
}
]
},
{
"description": "additionalItems does not look in applicators, invalid case",
"schema": {
Expand Down
16 changes: 0 additions & 16 deletions tests/draft7/additionalItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,22 +117,6 @@
}
]
},
{
"description": "additionalItems does not look in applicators, valid case",
"schema": {
"allOf": [
{ "items": [ { "type": "integer" } ] }
],
"additionalItems": { "type": "boolean" }
},
"tests": [
{
"description": "items defined in allOf are not examined",
"data": [ 1, null ],
"valid": true
}
]
},
{
"description": "additionalItems does not look in applicators, invalid case",
"schema": {
Expand Down
17 changes: 0 additions & 17 deletions tests/v1/additionalProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,23 +120,6 @@
}
]
},
{
"description": "additionalProperties does not look in applicators",
"schema": {
"$schema": "https://json-schema.org/v1",
"allOf": [
{"properties": {"foo": {}}}
],
"additionalProperties": {"type": "boolean"}
},
"tests": [
{
"description": "properties defined in allOf are not examined",
"data": {"foo": 1, "bar": true},
"valid": false
}
]
},
{
"description": "additionalProperties with null valued instance properties",
"schema": {
Expand Down
Loading