improvements #10
Open
improvements #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfolco
requested changes
Nov 13, 2019
| xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd"> | ||
|
|
||
| </schema> | ||
| <table name="${Table_Name}" resource="default" engine="innodb" comment="${Comment}"> |
Owner
There was a problem hiding this comment.
I'd rather keep fields out of the XML for these.
| <?php | ||
| \Magento\Framework\Component\ComponentRegistrar::register( | ||
| \Magento\Framework\Component\ComponentRegistrar::MODULE, | ||
| \Magento\Framework\Component\ComponentRegistrar::${Component_Type}, |
Owner
There was a problem hiding this comment.
Can you make it so that it defaults to MODULE if not specified? Like here: https://github.com/lfolco/phpstorm-m2-filetemplates/blob/master/M2%20composer.json.json#L5
| 'use strict'; | ||
|
|
||
| var config={ | ||
| map: { |
Owner
There was a problem hiding this comment.
We wouldn't always do a map in a requirejs-config, so maybe leave that part out? Also, rename to m2 requirejs-config.js.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves db_schema.xml
adds requireJS config
improves registration.php