Skip to content

improvements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improvements #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fca6c68
Adds Table structure to db_schema.xml
riconeitzel Oct 23, 2019
0c7b9dd
Adds requireJS Config Template
riconeitzel Oct 23, 2019
d25bb44
adds variable component type to registration.php
riconeitzel Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions M2 db_schema.xml.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<?xml version="1.0"?>

<schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">

</schema>
<table name="${Table_Name}" resource="default" engine="innodb" comment="${Comment}">
Copy link
Owner

@lfolco lfolco Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep fields out of the XML for these.


</table>
</schema>
2 changes: 1 addition & 1 deletion M2 registration.php.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
\Magento\Framework\Component\ComponentRegistrar::register(
\Magento\Framework\Component\ComponentRegistrar::MODULE,
\Magento\Framework\Component\ComponentRegistrar::${Component_Type},
Copy link
Owner

@lfolco lfolco Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it so that it defaults to MODULE if not specified? Like here: https://github.com/lfolco/phpstorm-m2-filetemplates/blob/master/M2%20composer.json.json#L5

'${VendorName_ModuleName}',
__DIR__
);
9 changes: 9 additions & 0 deletions M2 requireJS Config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

var config={
map: {
Copy link
Owner

@lfolco lfolco Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't always do a map in a requirejs-config, so maybe leave that part out? Also, rename to m2 requirejs-config.js.js

'*': {

}
}
};