refactor(update): use iterators instead channels #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(update): return better errors * fix also list update function * add updateError test * add back a missing return * minor changes * fix details message * Update internal/update/apt/service.go Co-authored-by: Davide <davideneri18@gmail.com> * Update internal/update/errors.go Co-authored-by: Davide <davideneri18@gmail.com> * Update internal/api/handlers/update.go Co-authored-by: Davide <davideneri18@gmail.com> * Update internal/api/handlers/update.go Co-authored-by: Davide <davideneri18@gmail.com> * Update internal/api/handlers/update.go Co-authored-by: Davide <davideneri18@gmail.com> * fix after code review --------- Co-authored-by: Davide <davideneri18@gmail.com>
lucarin91
force-pushed
the
update-use-iterators
branch
from
81b2b52 to
6b20319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change description
Additional Notes
Reviewer checklist
main.