Skip to content

Conversation

@nirinchev
Copy link
Collaborator

Proposed changes

Follow-up on #574 - cleaning up a few bits that seem to have been left behind after several code reorgs.

This is purely moving code around with no functional changes, but simplifies the logic by removing unnecessary variables and branches.

@nirinchev nirinchev requested a review from a team as a code owner September 23, 2025 10:39
@nirinchev nirinchev requested review from Copilot and gagik September 23, 2025 10:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a cleanup PR that simplifies the connection logic in the ConnectionManager by removing unnecessary variables and code branches. The changes maintain the same functionality while making the code more readable and maintainable.

Key changes:

  • Removed the unnecessary isOidcConnection boolean variable
  • Simplified the conditional logic by directly checking the auth type instead of using an intermediate variable
  • Restructured the if-else block to use early return pattern for better readability

@nirinchev nirinchev merged commit 91c99e5 into main Sep 23, 2025
17 of 18 checks passed
@nirinchev nirinchev deleted the ni/oidc-cleanup branch September 23, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants