Skip to content

chore: clean up ConnectionManager.connect #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

chore: clean up ConnectionManager.connect #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/common/connectionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ export class MCPConnectionManager extends ConnectionManager {
let serviceProvider: Promise<NodeDriverServiceProvider>;
let connectionInfo: ConnectionInfo;
let connectionStringAuthType: ConnectionStringAuthType = "scram";
let isOidcConnection: boolean = false;

try {
settings = { ...settings };
Expand Down Expand Up @@ -166,7 +165,6 @@ export class MCPConnectionManager extends ConnectionManager {
connectionInfo
);

isOidcConnection = connectionStringAuthType.startsWith("oidc");
serviceProvider = NodeDriverServiceProvider.connect(
connectionInfo.connectionString,
{
Expand All @@ -189,23 +187,22 @@ export class MCPConnectionManager extends ConnectionManager {
}

try {
if (!isOidcConnection) {
return this.changeState("connection-success", {
tag: "connected",
connectedAtlasCluster: settings.atlas,
serviceProvider: await serviceProvider,
connectionStringAuthType,
});
} else {
this.changeState("connection-request", {
if (connectionStringAuthType.startsWith("oidc")) {
return this.changeState("connection-request", {
tag: "connecting",
serviceProvider,
connectedAtlasCluster: settings.atlas,
connectionStringAuthType,
oidcConnectionType: connectionStringAuthType as OIDCConnectionAuthType,
});
return this.currentConnectionState;
}

return this.changeState("connection-success", {
tag: "connected",
connectedAtlasCluster: settings.atlas,
serviceProvider: await serviceProvider,
connectionStringAuthType,
});
} catch (error: unknown) {
const errorReason = error instanceof Error ? error.message : `${error as string}`;
this.changeState("connection-error", {
Expand Down
Loading