chore: Add running environment to telemetry VSCODE-352 #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tculig
changed the title
gagik
reviewed
Nov 10, 2025
src/telemetry/telemetryService.ts
Outdated
| return { | ||
| extension_version: `${version}`, | ||
| device_id: this.deviceId, | ||
| app_name: vscode.env.appName, // e.g., "Visual Studio Code" or "Azure Data Studio" |
Contributor
There was a problem hiding this comment.
could this be undefined? we should fallback to Visual Studio Code - Unknown or something like that
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, this should never be undefiend, but even if it is, is that an issue for the telemetry consumers?
Contributor
There was a problem hiding this comment.
yeah, just makes it more intentional / easier for us to track what scenario happened
himanshusinghs
approved these changes
Nov 10, 2025
gagik
approved these changes
Nov 10, 2025
tculig
deleted the
VSCODE-352-attach-running-environment-to-telemetry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vscode.env.appName is defined as "The application name of the editor, like 'VS Code'."
The expectation is that this will be "Azure Data Studio" when running inside Azure Data Studio.
Issue while testing: Latest version of Azure Data Studio uses vscode 1.82.0, which is now over 2 years old.
It doesn't support Chat participant features and some others which are being heavily used in our extension.
Making a build which will work with Azure Data Studio has thusly proved to be quite a blocker.
Also, notably, Microsoft is retiring Azure Data Studio on February 28th, 2026: https://azure.microsoft.com/en-us/products/data-studio
Example app_names:
Motivation and Context
Open Questions
Dependents
Types of changes