Skip to content

chore: Add running environment to telemetry VSCODE-352 #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2025
Merged

chore: Add running environment to telemetry VSCODE-352 #1181

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f698d0f
chore: Add running environment to telemetry
tculig Nov 10, 2025
cc9b985
Update telemetryService.test.ts
tculig Nov 10, 2025
b38ba81
Add default app_name for telemetry service
tculig Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/telemetry/telemetryService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ export class TelemetryService {
}

public getCommonProperties(): Record<string, string | undefined> {
return { extension_version: `${version}`, device_id: this.deviceId };
return {
extension_version: `${version}`,
device_id: this.deviceId,
app_name: vscode.env.appName, // e.g., "Visual Studio Code" or "Azure Data Studio"
Copy link
Contributor

@gagik gagik Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be undefined? we should fallback to Visual Studio Code - Unknown or something like that

Copy link
Contributor Author

@tculig tculig Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this should never be undefiend, but even if it is, is that an issue for the telemetry consumers?

Copy link
Contributor

@gagik gagik Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, just makes it more intentional / easier for us to track what scenario happened

};
}

private async readSegmentKey(): Promise<string | undefined> {
Expand Down Expand Up @@ -105,6 +109,7 @@ export class TelemetryService {
anonymousId: this.anonymousId,
traits: {
device_id: this.deviceId,
app_name: vscode.env.appName, // e.g., "Visual Studio Code" or "Azure Data Studio"
},
};

Expand Down
1 change: 1 addition & 0 deletions src/test/suite/telemetry/telemetryService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ suite('Telemetry Controller Test Suite', () => {
const commonProperties = {
extension_version: version,
device_id: testDeviceId,
app_name: vscode.env.appName,
};

const sandbox = sinon.createSandbox();
Expand Down