-
-
Notifications
You must be signed in to change notification settings - Fork 46
feat: added console bidi events #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes update how log entries are handled in tests/conftest.py. In the Changes
Sequence Diagram(s)sequenceDiagram
participant PT as Pytest Test Setup
participant LH as Lambda Handler
participant AR as Allure Reporter
PT->>LH: Register lambda to capture console message (__dict__)
PT->>LH: Register lambda to capture JS error (__dict__)
Note right of LH: Append structured log entries to lists
PT->>AR: On exception, serialize logs with json.dumps
AR-->>PT: Attach logs in JSON format to report
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit