Skip to content

feat: added console bidi events #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat: added console bidi events #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,13 @@ def pytest_runtest_setup(item: Item) -> None:
wait = WebDriverWait(driver, 10)
if browser != "remote":
console_messages = []
driver.script.add_console_message_handler(console_messages.append)
driver.script.add_console_message_handler(
lambda log_entry: console_messages.append(log_entry.__dict__)
)
javascript_errors = []
driver.script.add_javascript_error_handler(javascript_errors.append)
driver.script.add_javascript_error_handler(
lambda log_entry: javascript_errors.append(log_entry.__dict__)
)
item.cls.wait = wait
item.cls.about_page = AboutPage(driver, wait)
item.cls.login_page = LoginPage(driver, wait)
Expand Down Expand Up @@ -348,15 +352,15 @@ def pytest_exception_interact(node: Item) -> None:
# https://github.com/lana-20/selenium-webdriver-bidi
if console_messages:
allure.attach(
body="\n".join(str(message) for message in console_messages),
body=json.dumps(console_messages, indent=4),
name="Console Logs",
attachment_type=allure.attachment_type.TEXT,
attachment_type=allure.attachment_type.JSON,
)
if javascript_errors:
allure.attach(
body="\n".join(str(error) for error in javascript_errors),
body=json.dumps(javascript_errors, indent=4),
name="JavaScript Errors",
attachment_type=allure.attachment_type.TEXT,
attachment_type=allure.attachment_type.JSON,
)
# looks like cdp not working with remote: https://github.com/SeleniumHQ/selenium/issues/8672
if window_count == 1:
Expand Down