Skip to content

Conversation

@CuriousPanCake
Copy link
Contributor

Pin OpenVINO runtime commit to avoid circular dependency issues

Signed-off-by: Andrii Staikov andrii.staikov@intel.com

@github-actions github-actions bot added the category: GHA CI based on Github actions label Nov 12, 2025
@CuriousPanCake
Copy link
Contributor Author

Required for merging openvinotoolkit/openvino#32570
Otherwise, the GenAI code is going to be broken

@Wovchena
Copy link
Collaborator

What particular OV change is going to break GenAI? I though OV is going to extend its API, not shrink.

There's also probably backward incompatibility introduced by OV. Suppose someone has their own implementation which happens to match current OV GenAI exactly.

@CuriousPanCake
Copy link
Contributor Author

You're right, we'll have more code in runtime, less in GenAI, but

  1. Merging the runtime PR is not possible without pining the GenAI version. Otherwise, once it is merged, the GenAI code is not going to work correct: you're going to always have exceptions at the PA initialization stage hence falling back to the SDPA implementation.

  2. Similarly, it's not possible to merge the GenAI changes first as runtime is not supporting them yet: the CI is going to be red and the GenAI pipelines are not going to work properly.

That's why we thought it's going to be good to

  1. Pin the runtime version
  2. Merge OV runtime changes
  3. Merge GenAI changes

Please, let me know if you need more information

@Wovchena
Copy link
Collaborator

(2) is clear. My questions are about (1) (still not answered)

@mryzhov
Copy link
Contributor

mryzhov commented Nov 12, 2025

(2) is clear. My questions are about (1) (still not answered)
When we merge the new transformation in OV then models will be converted (sdpa->pa) by moc transformation and in genai pipeline the old transformation will fail on this model.

@mryzhov mryzhov closed this Nov 12, 2025
@mryzhov mryzhov reopened this Nov 12, 2025
@CuriousPanCake
Copy link
Contributor Author

Talked with Vladimir offline, he approves the changes

@Wovchena Wovchena added this pull request to the merge queue Nov 13, 2025
Merged via the queue into openvinotoolkit:master with commit aed499a Nov 13, 2025
192 of 195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GHA CI based on Github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants