TST: df.set_axis() and rename_axis() not failing when allows_duplicate_labels=False #63135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
reviewed
Nov 17, 2025
natmokval
reviewed
Nov 17, 2025
| result = df.rename_axis("idx", axis=0) | ||
| expected = DataFrame( | ||
| [[1, 2], [3, 4]], index=Index([0, 1], name="idx"), columns=["a", "b"] | ||
| ).set_flags(allows_duplicate_labels=False) |
Contributor
There was a problem hiding this comment.
One small comment:
I think we can define the expected DataFrame without specifying set_flags. Instead, in the assertion statement we can use check_flags=False.
Contributor
Author
There was a problem hiding this comment.
Agreed, looks much cleaner, thank you
Contributor
|
LGTM. @WillAyd, could you please take a look at these tests? |
WillAyd
approved these changes
Nov 18, 2025
Member
|
Thanks @kubaszkliniarz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.