-
Notifications
You must be signed in to change notification settings - Fork 340
Fix Fourier example images not building in documentation #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ate images Co-authored-by: juanitorduz <22996444+juanitorduz@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 68 68
Lines 9420 9420
=======================================
Hits 8720 8720
Misses 700 700 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
juanitorduz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adress the feedback @copilot
pymc_marketing/mmm/fourier.py
Outdated
| .. plot:: | ||
| :context: close-figs | ||
| :nofigs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot undo this change, we do not need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in commit 3ed3567. The setup code block is now back to code-block:: python.
pymc_marketing/mmm/fourier.py
Outdated
| .. plot:: | ||
| :context: close-figs | ||
| :nofigs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this change as we do not need it @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in commit 3ed3567. The hierarchical setup code block is now back to code-block:: python.
Co-authored-by: juanitorduz <22996444+juanitorduz@users.noreply.github.com>
juanitorduz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: juanitorduz <22996444+juanitorduz@users.noreply.github.com>
|
@williambdean WDYT? |
code-blockdirectives in fourier.py don't execute code or generate imagescode-block:: pythondirectives toplot::directives for examples that generate plots (lines 73-94, 124-145)Summary
Fixed rendering issues by including setup code in plot directives:
Each plot directive is now self-contained with all necessary imports and setup code, ensuring the
yearlyvariable is properly defined when the plot executes. The setup code is still shown separately incode-block::directives for educational reference, but the plot directives contain complete working examples.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
📚 Documentation preview 📚: https://pymc-marketing--2067.org.readthedocs.build/en/2067/