Skip to content

Fix Fourier example images not building in documentation #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2025
+29 −2
Merged

Fix Fourier example images not building in documentation #2067

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
53f1f7c
Initial plan
Copilot Nov 4, 2025
85a3fe2
Convert code-block to plot directives for Fourier examples that gener…
Copilot Nov 4, 2025
3ed3567
Revert setup code blocks to code-block directive per review feedback
Copilot Nov 4, 2025
582e9c2
Add setup code to plot directives to fix rendering issues
Copilot Nov 4, 2025
155241a
Merge branch 'main' into copilot/fix-fourier-image-building
juanitorduz Nov 4, 2025
5b2919a
Merge branch 'main' into copilot/fix-fourier-image-building
juanitorduz Nov 5, 2025
a7f9a97
Merge branch 'main' into copilot/fix-fourier-image-building
juanitorduz Nov 10, 2025
f89f24e
Merge branch 'main' into copilot/fix-fourier-image-building
juanitorduz Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pymc_marketing/mmm/fourier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@
--------
Use yearly fourier seasonality for custom Marketing Mix Model.
.. code-block:: python
.. plot::
:context: close-figs
:nofigs:
Copy link
Collaborator

@juanitorduz juanitorduz Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot undo this change, we do not need this

Copy link
Contributor Author

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in commit 3ed3567. The setup code block is now back to code-block:: python.

import pandas as pd
import pymc as pm
Expand All @@ -70,7 +72,8 @@
Plot the prior fourier seasonality trend.
.. code-block:: python
.. plot::
:context: close-figs
import matplotlib.pyplot as plt
Expand All @@ -91,7 +94,9 @@
Even make it hierarchical...
.. code-block:: python
.. plot::
:context: close-figs
:nofigs:
Copy link
Collaborator

@juanitorduz juanitorduz Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change as we do not need it @copilot

Copy link
Contributor Author

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in commit 3ed3567. The hierarchical setup code block is now back to code-block:: python.

from pymc_marketing.mmm import YearlyFourier
from pymc_extras.prior import Prior
Expand All @@ -107,7 +112,8 @@
All the plotting will still work! Just pass any coords.
.. code-block:: python
.. plot::
:context: close-figs
import matplotlib.pyplot as plt
Expand Down
Loading