Fix double trap #2163
Merged
Fix double trap #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the following change needs to access menvcfg in mstatus's member function. Signed-off-by: Chih-Min Chao <chihmin.chao@sifive.com>
Contributor
Author
|
@ved-rivos You may be interested. |
aswaterman
reviewed
Nov 26, 2025
aswaterman
reviewed
Nov 26, 2025
aswaterman
reviewed
Nov 26, 2025
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
Thanks for splitting the commits to make this PR easy to review.
Ping me once you've addressed my comments and I'll merge it. (@ved-rivos is on vacation)
In privilege spec sec 3.1.18 " The Ssdbltrp extension adds the double-trap-enable ( DTE ) field in menvcfg . When menvcfg.DTE is zero, the implementation behaves as though Ssdbltrp is not implemented. When Ssdbltrp is not implemented sstatus.SDT , vsstatus.SDT , and henvcfg.DTE bits are read-only zero." The change keep the mstatus.sdt unchangedable and always read-as-zero when menvcfg.dte is cleared Signed-off-by: Chih-Min Chao <chihmin.chao@sifive.com>
chihminchao
force-pushed
the
fix-double-trap
branch
from
14258a4 to
6d6cc2c
Compare
Contributor
Author
|
@aswaterman It is ready |
aswaterman
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.