Improve assertions for extension friendliness; add DebuggerTypeProxy for InMemorySink; minor docs fix #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
Serilog.Sinks.InMemorydeveloper experience and assertions ecosystem:DebuggerTypeProxyforInMemorySinkto provide a cleaner debugging view.InMemorySinkExtensionsto improve clarity and extensibility.README.md.Changes
src/Serilog.Sinks.InMemory/InMemorySinkAdvDebugProxy.csand applied[DebuggerTypeProxy]toInMemorySink.src/Serilog.Sinks.InMemory/InMemorySink.csto improve snapshot handling and thread-safety around_logEventsand_logEventsSnapshot.FluentAssertions5/6/7/8,Shouldly4, and introducedAwesomeAssertions8/9implementations.src/Serilog.Sinks.InMemory.Assertions/InMemorySinkExtensions.csto better support extension scenarios.Serilog.Sinks.InMemory.Assertions.Abstractionsincluding.csproj.README.mdtypo/wording fix.Motivation and Context
InMemorySinkinstances was noisy; the newDebuggerTypeProxystreamlines inspection during tests and development.Implementation Notes
InMemorySinkmaintains an internal_logEventslist and_logEventsSnapshotwith a lock (_snapShotLock) to keep reads fast and consistent while writes invalidate the snapshot.[DebuggerTypeProxy(typeof(InMemorySinkAdvDebugProxy))]attribute presents key information without exposing internal implementation details.InMemorySinkExtensionsrefactor reduces duplication and clarifies extension points used by multiple assertion packages.Breaking Changes
DebuggerTypeProxychanges the visual representation in debuggers.Performance Considerations