Gather cloud factsv2 #1869
Gather cloud factsv2 #1869
Conversation
GavinHeff
force-pushed
the
gatherCloudFactsv2
branch
4 times, most recently
from
97bc20e to
d199d9a
Compare
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new playbook to gather more detailed facts about the cloud environment, supported by a new custom Ansible filter. While the overall direction is good, the new filter plugin in filters.py contains several issues, including a critical bug that silences errors, leftover debugging comments, and inconsistencies. The get-cloud-facts.yml playbook also has some potential problems, such as a misleading fact name and unsafe variable access that could lead to playbook failures. I have provided specific comments and code suggestions to address these issues and improve the robustness and clarity of the new code.
Alex-Welsh
force-pushed
the
gatherCloudFactsv2
branch
from
d199d9a to
1c70988
Compare
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
GavinHeff
force-pushed
the
gatherCloudFactsv2
branch
2 times, most recently
from
9949f32 to
8b1311e
Compare
GavinHeff
force-pushed
the
gatherCloudFactsv2
branch
from
8b1311e to
5cb8111
Compare
GavinHeff
force-pushed
the
gatherCloudFactsv2
branch
from
5cb8111 to
1bfbb2b
Compare
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
Looking good, just a few minor tweaks
|
You'll also need to rebase this on stackhpc/2025.1. In a recent change, all the ansible playbooks were moved to separate sub-directories, so there's a conflict where the playbook moved |
edits from review
GavinHeff
force-pushed
the
gatherCloudFactsv2
branch
from
a021da8 to
254b2b7
Compare
Adds playbook to gather more advanced facts about a multinode cloud