crud: refactor optional types to use go-option #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Later, I'll add the Tuple and Any type to the go-option library and make the code even more typesafe. |
oleg-jukovec
requested changes
Nov 25, 2025
The welcome flags for the IPROTO_FEATURE_IS_SYNC functions have been added and IPROTO_FEATURE_INSERT_ARROW for IPROTO_FEATURE_INSERT_ARROW protocol functions. Changed it CHANGELOG.md in the previous version, it was in the wrong version. Changed #466
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
2 times, most recently
from
499ecc6 to
21bd65d
Compare
Collaborator
Author
|
The required changes have been added. |
Collaborator
|
The commit message should be something like: -> |
oleg-jukovec
requested changes
Dec 1, 2025
| added `IsSync(bool)` method for `BeginRequest`/`CommitRequest` (#447). | ||
| - Added missing IPROTO feature flags to greeting negotiation | ||
| (iproto.IPROTO_FEATURE_IS_SYNC, iproto.IPROTO_FEATURE_INSERT_ARROW) (#466). | ||
|
|
Collaborator
There was a problem hiding this comment.
Please, remove the extra line:
Suggested change
crud/get.go
Outdated
| VshardRouter option.String | ||
| // Fields is field names for getting only a subset of fields. | ||
| Fields OptTuple | ||
| Fields option.Any // Type Any is instead of a local type Tuple. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Fields option.Any // Type Any is instead of a local type Tuple. | |
| Fields option.Any |
crud/options.go
Outdated
| values := [optsCnt]interface{}{} | ||
| exists := [optsCnt]bool{} | ||
| values[0], exists[0] = opts.Timeout.Get() | ||
| values[0], exists[0] = opts.Timeout.Get() // Method Get() from go-options is same. |
Collaborator
There was a problem hiding this comment.
Suggested change
| values[0], exists[0] = opts.Timeout.Get() // Method Get() from go-options is same. | |
| values[0], exists[0] = opts.Timeout.Get() |
crud/compile_test.go
Outdated
Comment on lines
55
to
56
| // TestSomeAny checks the operation of SomeAny. | ||
| func TestSomeAny(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
It looks like we don't need this test. Please delete it if so.
crud/compile_test.go
Outdated
Comment on lines
11
to
12
| // TestOptionTypesCompilation verifies that all option types are compiled correctly. | ||
| func TestOptionTypesCompilation(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Same here. I don't understand why we need this test. Please, remove it if we don't need it.
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
2 times, most recently
from
e6f4b4e to
f2c9c14
Compare
- Remove: OptUint, OptInt, OptFloat64, OptString, OptBool, OptTuple. - Remove: MakeOptUint, MakeOptInt, MakeOptFloat64, MakeOptString, MakeOptBool, MakeOptTuple. - Update: All option structs to use option.* types. - Add type Any from go-option. - Fix: Test type inconsistencies. Closes #492
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
from
f2c9c14 to
6ac2dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed #492