[CI] lora/test_mixtral.py : Add additional expected outputs due to flakiness #28322
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Sundar Rabindranath <vsundarr@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test in lora/test_mixtral.py by expanding the set of expected outputs to account for non-deterministic argument ordering from the model. This is a good approach to improve CI stability. I've added one suggestion to further enhance the robustness of the test by applying the same logic to another prompt that could exhibit similar flakiness.
Contributor
Author
Signed-off-by: Varun Sundar Rabindranath <vsundarr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Distributed A100 tests fail the nightly due to
lora/test_mixtral.pylinkThis PR attempts to fix that test. Running the test locally, I found it to be flaky. However, the output generated by the LLM is still reasonable. As a fix, I have added an additional "expected_output" to the prompt that is flaky.
Test Plan
CI
Test Result