Skip to content

[CI] lora/test_mixtral.py : Add additional expected outputs due to flakiness #28322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
+18 −11
Merged

[CI] lora/test_mixtral.py : Add additional expected outputs due to flakiness #28322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b8df0b
Add additional expected outputs due to flakiness
Nov 7, 2025
ae3f136
better check
Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions tests/lora/test_mixtral.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,22 @@ def test_mixtral_lora(mixtral_lora_files, tp_size):
)

expected_lora_output = [
"give_opinion(name[SpellForce 3], release_year[2017], developer[Grimlore Games], rating[poor])", # noqa: E501
"give_opinion(name[SpellForce 3], developer[Grimlore Games], release_year[2017], rating[poor])", # noqa: E501
"inform(name[BioShock], release_year[2007], rating[good], genres[action-adventure, role-playing, shooter], platforms[PlayStation, Xbox, PC], available_on_steam[yes], has_linux_release[no], has_mac_release[yes])", # noqa: E501
[
"give_opinion(name[SpellForce 3], release_year[2017], developer[Grimlore Games], rating[poor])" # noqa: E501
],
[
"give_opinion(name[SpellForce 3], developer[Grimlore Games], release_year[2017], rating[poor])", # noqa: E501
"give_opinion(name[SpellForce 3], release_year[2017], developer[Grimlore Games], rating[poor])", # noqa: E501
],
[
"inform(name[BioShock], release_year[2007], rating[good], genres[action-adventure, role-playing, shooter], platforms[PlayStation, Xbox, PC], available_on_steam[yes], has_linux_release[no], has_mac_release[yes])" # noqa: E501
],
]
assert (
do_sample(llm, mixtral_lora_files, lora_id=1, prompts=prompts)
== expected_lora_output
)
assert (
do_sample(llm, mixtral_lora_files, lora_id=2, prompts=prompts)
== expected_lora_output
)

def check_outputs(generated: list[str]):
assert len(generated) == len(expected_lora_output)
for gen, gt_choices in zip(generated, expected_lora_output):
assert gen in gt_choices

check_outputs(do_sample(llm, mixtral_lora_files, lora_id=1, prompts=prompts))
check_outputs(do_sample(llm, mixtral_lora_files, lora_id=2, prompts=prompts))