Add decryption/encryption dedicated APIs #288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidou
reviewed
Nov 20, 2025
index.bs
Outdated
| <pre class="idl"> | ||
| typedef (SFrameTransform or RTCRtpScriptTransform) RTCRtpTransform; | ||
| typedef (SFrameSenderTransform or RTCRtpScriptTransform) RTCRtpSenderTransform; | ||
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceierTransform; |
Collaborator
There was a problem hiding this comment.
typo RTCRtpReceierTransform -> RTCRtpReceiverTransform
youennf
commented
Nov 20, 2025
guidou
reviewed
Nov 20, 2025
index.bs
Outdated
| 1. [=Resolve=] |promise| with undefined. | ||
| 1. Return |promise|. | ||
|
|
||
| // FIXME: Should SFrameTransform receiver be made aware of the current key in use, so that it would call removeEncryptionKey appropriately. |
Collaborator
There was a problem hiding this comment.
remove fixme and file an issue instead
youennf
commented
Nov 20, 2025
Removing fixme in favour of w3c#289
youennf
commented
Nov 20, 2025
jan-ivar
reviewed
Nov 20, 2025
index.bs
Outdated
| <pre class="idl"> | ||
| typedef (SFrameTransform or RTCRtpScriptTransform) RTCRtpTransform; | ||
| typedef (SFrameSenderTransform or RTCRtpScriptTransform) RTCRtpSenderTransform; | ||
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceierTransform; |
Member
There was a problem hiding this comment.
Suggested change
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceierTransform; | |
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceiverTransform; |
| 1. If |keyID| is a {{bigint}} which cannot be represented as a integer between 0 and 2<sup>64</sup>-1 inclusive, [=reject=] |promise| with a {{RangeError}} exception and abort these steps. | ||
| 1. Set |this|.`[[currentKeyId]]` to |keyId|. | ||
| 1. [=In parallel=], run the following steps: | ||
| 1. Set |key| and |keyID| as key material to use for the SFrame transform encryption algorithm, as defined by [[RFC9605]]. |
Member
There was a problem hiding this comment.
Nit: "Set as" is a bit confusing to me. It's the reverse of (yet similar looking to) "set a to b" which usually means a = b, not b = a... How about:
Suggested change
| 1. Set |key| and |keyID| as key material to use for the SFrame transform encryption algorithm, as defined by [[RFC9605]]. | |
| 1. Set the SFrame transform encryption algorithm's key material to |key| and |keyID|, as defined by [[RFC9605]]. |
| 1. [=Queue a task=] to [=resolve=] |promise| with undefined. | ||
| 1. Return |promise|. | ||
|
|
||
| The <dfn method for="SFrameDecrypterKeyManager">addEncryptionKey(|key|, |keyID|)</dfn> method steps are: |
Member
There was a problem hiding this comment.
Suggested change
| The <dfn method for="SFrameDecrypterKeyManager">addEncryptionKey(|key|, |keyID|)</dfn> method steps are: | |
| The <dfn method for="SFrameDecrypterKeyManager">addDecryptionKey(|key|, |keyID|)</dfn> method steps are: |
guidou
approved these changes
Nov 20, 2025
jan-ivar
reviewed
Nov 20, 2025
| 1. [=Resolve=] |promise| with undefined. | ||
| 1. Return |promise|. | ||
|
|
||
| The <dfn method for="SFrameDecrypterKeyManager">removeEncryptionKey(|key|, |keyID|)</dfn> method steps are: |
Member
There was a problem hiding this comment.
Suggested change
| The <dfn method for="SFrameDecrypterKeyManager">removeEncryptionKey(|key|, |keyID|)</dfn> method steps are: | |
| The <dfn method for="SFrameDecrypterKeyManager">removeDecryptionKey(|key|, |keyID|)</dfn> method steps are: |
jan-ivar
reviewed
Nov 20, 2025
Comment on lines
+375
to
+376
| 1. Let |keyStore| be the key store used for the SFrame transform algorithm, as defined by [[RFC9605]]. | ||
| 1. Set an entry to |keyStore| with |keyId| as key and |keyValue| as value. This overrides any existing entry to |keyId|. |
Member
There was a problem hiding this comment.
I see "key store" matches language in RFC9605, which is nice.
But I also wonder if we could use infra here. Is it an https://infra.spec.whatwg.org/#ordered-map ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Preview | Diff