-
Notifications
You must be signed in to change notification settings - Fork 28
Add decryption/encryption dedicated APIs #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -81,15 +81,16 @@ It uses an additional API on {{RTCRtpSender}} and {{RTCRtpReceiver}} to | |||||
| insert the processing into the pipeline. | ||||||
|
|
||||||
| <pre class="idl"> | ||||||
| typedef (SFrameTransform or RTCRtpScriptTransform) RTCRtpTransform; | ||||||
| typedef (SFrameSenderTransform or RTCRtpScriptTransform) RTCRtpSenderTransform; | ||||||
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceierTransform; | ||||||
|
||||||
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceierTransform; | |
| typedef (SFrameReceiverTransform or RTCRtpScriptTransform) RTCRtpReceiverTransform; |
youennf marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "Set as" is a bit confusing to me. It's the reverse of (yet similar looking to) "set a to b" which usually means a = b, not b = a... How about:
| 1. Set |key| and |keyID| as key material to use for the SFrame transform encryption algorithm, as defined by [[RFC9605]]. | |
| 1. Set the SFrame transform encryption algorithm's key material to |key| and |keyID|, as defined by [[RFC9605]]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The <dfn method for="SFrameDecrypterKeyManager">addEncryptionKey(|key|, |keyID|)</dfn> method steps are: | |
| The <dfn method for="SFrameDecrypterKeyManager">addDecryptionKey(|key|, |keyID|)</dfn> method steps are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see "key store" matches language in RFC9605, which is nice.
But I also wonder if we could use infra here. Is it an https://infra.spec.whatwg.org/#ordered-map ?
youennf marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove fixme and file an issue instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
youennf marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The <dfn method for="SFrameDecrypterKeyManager">removeEncryptionKey(|key|, |keyID|)</dfn> method steps are: | |
| The <dfn method for="SFrameDecrypterKeyManager">removeDecryptionKey(|key|, |keyID|)</dfn> method steps are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo RTCRtpReceierTransform -> RTCRtpReceiverTransform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed