zvfofp4min: fix shared contraint with v[zs]ext #2162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
approved these changes
Nov 26, 2025
aswaterman
requested changes
Nov 26, 2025
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
Actually, I think the require(((float)P.VU.vflmul / div) >= 0.125 && ((float)P.VU.vflmul / div) <= 8 ); should remain common code. I agree that the require(from >= e8 && from <= e64); needs to be factored out since SEW / div equals 4 in the vfext case.
Signed-off-by: Chih-Min Chao <chihmin.chao@sifive.com>
chihminchao
force-pushed
the
fix-zvfofp4min-contraint
branch
from
ee16c42 to
755ad71
Compare
Contributor
Author
|
follow the suggestion to refine the common part. |
aswaterman
approved these changes
Nov 30, 2025
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rules are not common.